Skip to content

refactor: rename RowIdMask to RowAddrMask#5281

Merged
yanghua merged 3 commits intolance-format:mainfrom
yanghua:rename-RowIdMask
Dec 20, 2025
Merged

refactor: rename RowIdMask to RowAddrMask#5281
yanghua merged 3 commits intolance-format:mainfrom
yanghua:rename-RowIdMask

Conversation

@yanghua
Copy link
Copy Markdown
Collaborator

@yanghua yanghua commented Nov 19, 2025 •
edited
Loading

sub-task of #5326

@yanghua yanghua marked this pull request as ready for review November 19, 2025 13:09
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 91.25000% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-index/src/vector/flat/index.rs 55.55% 4 Missing ⚠️
rust/lance/src/io/exec/filtered_read.rs 50.00% 2 Missing and 2 partials ⚠️
rust/lance-index/src/scalar/expression.rs 91.66% 1 Missing and 1 partial ⚠️
rust/lance/src/index/vector/pq.rs 0.00% 2 Missing ⚠️
rust/lance-core/src/utils/mask/nullable.rs 88.88% 0 Missing and 1 partial ⚠️
rust/lance/src/io/exec/utils.rs 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@yanghua
Copy link
Copy Markdown
Collaborator Author

yanghua commented Dec 8, 2025

This work is a subtask of this issue. #5326

@yanghua yanghua requested a review from jackye1995 December 8, 2025 09:03
@yanghua
Copy link
Copy Markdown
Collaborator Author

yanghua commented Dec 8, 2025

@jackye1995, please take a look, thanks.

@yanghua yanghua requested a review from wjones127 December 9, 2025 00:40
@yanghua
Copy link
Copy Markdown
Collaborator Author

yanghua commented Dec 16, 2025

Hi @jackye1995 @wjones127 Please take a look, when you have time.

majin1102
majin1102 approved these changes Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@majin1102 majin1102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a light name changing from row_id to row_addr. Looks good to me

yanghua
yanghua commented Dec 19, 2025
View reviewed changes
Comment thread rust/lance/src/session/caches.rs
jackye1995
jackye1995 reviewed Dec 20, 2025
View reviewed changes
Comment thread rust/lance-core/src/utils/mask/nullable.rs
jackye1995
jackye1995 reviewed Dec 20, 2025
View reviewed changes
Comment thread rust/lance-core/src/utils/mask.rs Outdated
jackye1995
jackye1995 reviewed Dec 20, 2025
View reviewed changes
Comment thread rust/lance/src/io/exec/knn.rs Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 20, 2025

Review Summary

This is a clean mechanical rename refactoring from RowIdMask to RowAddrMask (and related types like NullableRowIdMask → NullableRowAddrMask, iter_ids → iter_addrs). The changes are part of the larger effort in #5326 to distinguish between row address and stable row ID semantics.

Assessment: ✅ LGTM

No P0/P1 issues found.

The refactoring is straightforward and consistent:

  • All type renames are applied uniformly across the codebase
  • Variable names are updated to match (e.g., row_id → row_addr where appropriate)
  • Comments and documentation updated to reflect the new terminology
  • Test names updated (test_row_id_mask → test_row_addr_mask)
  • No behavioral changes - pure rename refactoring

The coverage gaps reported by Codecov are on pre-existing uncovered lines, not regressions introduced by this PR.

jackye1995
jackye1995 approved these changes Dec 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jackye1995 jackye1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@yanghua yanghua merged commit 119f87b into lance-format:main Dec 20, 2025
29 of 30 checks passed
wjones127 pushed a commit to wjones127/lance that referenced this pull request Dec 30, 2025
@yanghua @wjones127
refactor: rename RowIdMask to RowAddrMask (lance-format#5281)
1117e65
jackye1995 pushed a commit to jackye1995/lance that referenced this pull request Jan 21, 2026
@yanghua @jackye1995
refactor: rename RowIdMask to RowAddrMask (lance-format#5281)
f8c0bd0
@andrea-reale andrea-reale mentioned this pull request Mar 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majin1102 majin1102 majin1102 approved these changes

@jackye1995 jackye1995 jackye1995 approved these changes

@wjones127 wjones127 Awaiting requested review from wjones127

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yanghua @majin1102 @jackye1995